Skip to content

Add analysis library for radare2 v5.8.8 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 8, 2023
Merged

Add analysis library for radare2 v5.8.8 #495

merged 16 commits into from
Oct 8, 2023

Conversation

@sidra-asa
Copy link
Collaborator

@sidra-asa sidra-asa commented Mar 28, 2023 •
edited
Loading

Close #481

Code change

  • .github/workflows/pytest.yml
  • Pipfile
  • quark/cli.py
  • quark/core/quark.py
  • quark/core/rzapkinfo.py
  • quark/utils/tools.py
  • setup.py
  • tests/core/test_apkinfo.py
  • tests/core/test_rzapkinfo.py

Code add

  • quark/core/r2apkinfo.py
  • tests/core/test_r2apkinfo.py

@sidra-asa sidra-asa force-pushed the r2_lib branch 2 times, most recently from 1388cd7 to f41e527 Compare April 1, 2023 15:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023 •
edited
Loading

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
quark/cli.py 0.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
tests/core/test_apkinfo.py 100.00% <100.00%> (+3.75%) ⬆️
tests/core/test_axmlreader.py 100.00% <100.00%> (ø)
quark/core/axmlreader/__init__.py 89.47% <95.45%> (+0.15%) ⬆️
quark/core/quark.py 72.06% <66.66%> (-0.06%) ⬇️
quark/core/r2apkinfo.py 59.02% <59.02%> (ø)

📢 Thoughts on this report? Let us know!.

@haeter525 haeter525 self-assigned this May 14, 2023
@sidra-asa sidra-asa force-pushed the r2_lib branch 6 times, most recently from b781ec0 to 24f9a58 Compare September 3, 2023 13:50
haeter525
haeter525 requested changes Sep 19, 2023
View reviewed changes
@pep8speaks
Copy link

pep8speaks commented Sep 20, 2023 •
edited
Loading

Hello @sidra-asa! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 136:80: E501 line too long (80 > 79 characters)

Line 140:80: E501 line too long (81 > 79 characters)
Line 303:80: E501 line too long (80 > 79 characters)

Line 2:80: E501 line too long (82 > 79 characters)
Line 61:80: E501 line too long (83 > 79 characters)
Line 154:80: E501 line too long (85 > 79 characters)
Line 491:80: E501 line too long (82 > 79 characters)

Line 408:5: E303 too many blank lines (2)

Line 15:1: E303 too many blank lines (3)

Comment last updated at 2023-10-06 02:51:10 UTC

@sidra-asa sidra-asa force-pushed the r2_lib branch 2 times, most recently from b29ffee to 2b5013e Compare September 21, 2023 17:46
haeter525
haeter525 requested changes Sep 22, 2023
View reviewed changes
@haeter525 haeter525 marked this pull request as ready for review October 5, 2023 12:05
haeter525
haeter525 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@haeter525 haeter525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank @sidra-asa. @haeter525 approves.

@haeter525 haeter525 changed the title Add analysis library for radare2 v5.x.x Add analysis library for radare2 v5.8.8 Oct 8, 2023
@haeter525 haeter525 merged commit 5ce6e39 into ev-flow:master Oct 8, 2023
@sidra-asa sidra-asa mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haeter525 haeter525 haeter525 approved these changes

Assignees

@haeter525 haeter525

Labels

pr-processing-state-06

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add analysis library for radare2 v5.x.x

4 participants

@sidra-asa @codecov-commenter @pep8speaks @haeter525